cadop / dhart

A library for Navigation Graphs, Visibility, Raycasting and other features for Design Humans Analysis RoboTics (DHART).

Home Page:https://cadop.github.io/dhart/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Overloads for C# interface to accept floats

cadop opened this issue · comments

commented

port optimizations from OcclusionRays to other methods such as this one ?

internal static CVectorAndData C_IntersectRays(
IntPtr ray_tracer,
IEnumerable<Vector3D> origins,
IEnumerable<Vector3D> directions,
float max_distance
)

Originally posted by @mariuszhermansdorfer in #46 (comment)

@cadop,
I added overloads to the remaining methods to accept float[] as input as well. Would you like me to push these to the dev branch as well?
image

commented

@mariuszhermansdorfer yes that would be great thank you!

commented

Also I just realized what your comment was. I thought it was talking about OpenMP, which is what I did on the dev branch recently. Now I see what you asked!

Your initial interpretation was right - I asked to port all optimizations to other methods as well. Both the float[] input and OpenMP

Could you point me to where the OpenMP are optimizations are in the previous code so that I could try and scale it to the other methods?

commented

I already did the update to openmp on dev