Role for features

Question

Role for features

meadsteve opened this issue 5 years ago · comments

Steve Brazier commented 5 years ago

Whitebread has some filters that make use of a 'role' for a feature.

This was removed here: e838907#diff-d25be551329fc7c7234e014e4d849b9fL157

Any opposition to adding it back?

Roberts Guļāns · Answer 1 · Thu Apr 11 2019 02:38:25 GMT+0800 (China Standard Time)

Yeah, if it is in gherkin/cucumber documentation than 100% yes. Otherwise, roles still seem like a very handy tool and will be implemented after 1.0 release (wonder when that will be as least weeks being sick and having much work to do beside this library).

Steve Brazier · Answer 2 · Sat Apr 13 2019 18:34:19 GMT+0800 (China Standard Time)

@revati I'm not sure it's actually part of the gherkin spec but it is useful. Given that the removal of role is a breaking change I'd say it's important to mark the library as 2.0 before the current master gets released

Steve Brazier · Answer 3 · Mon Apr 15 2019 17:08:23 GMT+0800 (China Standard Time)

Which I see has already been done 👍 So nevermind.

This will be a breaking change for whitebread so I'm happy to attempt to re-implent roles in gherkin (once things are stable in 2.0).