Cannot type spaces
Frando opened this issue · comments
With cabal 5.2.0 I cannot type any spaces.
Tested with Termite + tmux, Termite without tmux, Gnome Terminal. Node 11, arch linux.
Yeah hmmm this was an issue we discovered at 35c3 before 5.2.0, now I just have to figure out how to replicate it
scratches head
@cblgh Are you running mac and can't reproduce?
@ralphtheninja yeah, and a debian server running a cli session in tmux
albeit i've been running straight from the repo code and not a globally installed npm i -g cabal, so there could be a discrepancy there somehow
I also have this problem running arch linux with urxvt as the terminal
found the problem! i made a pr
edit: the issue was neat-input had been updated to emit a space event, but it seems the implementation made it so that the space was eaten up by neat-input!
this is why i couldn't repro, my local node_modules had the version prior to the patch, while everyone trying cabal for the first time were grabbing the latest neat-input via npm! i think package-lock would probably have prevented this
package-lock is pretty damn broken/unstable, i had an argument with the devs about that issue.
I think i ended up with the recommendation to manually shrinkwrap before each release:
npm shrinkwrap generates a publishable lock-file.
EDIT: uh nvm, I misunderstood the situation, well yeah a commited&published shrinkwrap json would've done pretty much the same thing as a package-lock.json except you have to generate it manually which opens up another dimension for errors :) , The issue i had with package-lock.json is that npm silently breaks the lock depending on npm version, so unless all devs are using latest npm and node version the lock will be constantly get broken between each commit. :(
neat-input has been updated, the spaces have been freed!
🎈 🎈 🎈