ca-x / vivaldi_plus

根据shuax chrome_plus 修改

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Sweep:Please fix rightDoubleClick cause windows in black

czyt opened this issue · comments

Checklist
  • src/TabBookmark.h ✅ Commit 5c00ed1

Here's the PR! #43.

⚡ Sweep Free Trial: I'm creating this ticket using GPT-4. You have 1 GPT-4 tickets left for the month and 2 for the day. For more GPT-4 tickets, visit our payment portal.

Actions (click)

  • ↻ Restart Sweep

Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description.

https://github.com/czyt/vivaldi_plus/blob/4a6a3e22c44943fef6a62ad254ef7788141295eb/src/TabBookmark.h#L321-L472

https://github.com/czyt/vivaldi_plus/blob/4a6a3e22c44943fef6a62ad254ef7788141295eb/src/featuresFlag.h#L1-L18

https://github.com/czyt/vivaldi_plus/blob/4a6a3e22c44943fef6a62ad254ef7788141295eb/src/appid.h#L1-L41

https://github.com/czyt/vivaldi_plus/blob/4a6a3e22c44943fef6a62ad254ef7788141295eb/src/hijack.h#L1-L150


Step 2: ⌨️ Coding

  • src/TabBookmark.h ✅ Commit 5c00ed1
• In the `MouseProc` function, modify the condition that checks if a right double-click event has occurred and the `EnableRightClickCloseTab` flag is enabled. Add an additional check to ensure that there is more than one tab open before closing the current tab. This can be done by using the `IsOnlyOneTab` function.
• If the `IsOnlyOneTab` function returns true, do not close the tab. Instead, you could show a message to the user indicating that the last tab cannot be closed, or simply do nothing.

Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/fix-right-double-click.

.


🎉 Latest improvements to Sweep:

  • Sweep can now passively improve your repository! Check out Rules to learn more.

💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request.
Join Our Discord