not compatible with lastools v2.0.3 or recent pdal
landryb opened this issue · comments
while building against external lastools 2.3.0, the build fails with
/usr/obj/ports/displaz-0.4.0/displaz-0.4.0/src/las_io.cpp:185:49: error: no matching constructor for initialization of 'LASreaderLAS'
std::unique_ptr<LASreaderLAS> lasReader(new LASreaderLAS());
^
/usr/local/include/LASlib/lasreader_las.hpp:79:3: note: candidate constructor not viable: requires single argument 'opener', but no arguments were provided
LASreaderLAS(LASreadOpener* opener);
^
/usr/local/include/LASlib/lasreader_las.hpp:61:18: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 0 were provided
class LASLIB_DLL LASreaderLAS : public LASreader
i've tried building against pdal instead of lastools, but with version 2.7, and the current code uses apis that were removed in PDAL 1.2.
/usr/obj/ports/displaz-0.4.0/displaz-0.4.0/src/las_io.cpp:83:45: error: no type named 'Reader' in namespace 'pdal'
pdal::Stage* reader = static_cast<pdal::Reader*>(manager->getStage());
~~~~~~^
/usr/obj/ports/displaz-0.4.0/displaz-0.4.0/src/las_io.cpp:90:11: error: no type named 'PointBufferSet' in namespace 'pdal'
pdal::PointBufferSet pbSet = manager->buffers();
~~~~~~^
/usr/obj/ports/displaz-0.4.0/displaz-0.4.0/src/las_io.cpp:90:43: error: no member named 'buffers' in 'pdal::PipelineManager'
pdal::PointBufferSet pbSet = manager->buffers();
~~~~~~~~~^
/usr/obj/ports/displaz-0.4.0/displaz-0.4.0/src/las_io.cpp:92:24: error: use of undeclared identifier 'context'; did you mean 'connect'?
pdal::PointContext context = manager->context();
the pipeline reader has been merged into pipeline manager, cf https://github.com/PDAL/PDAL/blob/282386ee59e4c204d6400d5813f2a0be82f29312/RELEASENOTES.txt#L1579
@nigels-com since you seem to be the new maintainer, any idea about that ?
@landryb Thanks for the issue, time to migrate, I guess!
Never mind. Having the same issue with v2.0.3.
Try: PR #231
yes, it builds fine with #231 !
Should work fine, I have not done any testing yet though!
Fixed.