Giters

byterocket / c4-common-issues

A collection of common security issues and possible gas optimizations in solidity smart contracts

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Remove or adjust G006

pcaversaccio opened this issue · comments

commented

Remove or adjust: G006 - immutable for OpenZeppelin AccessControl's Roles Declarations

Since Solidity version 0.6.12 the keccak256 of string literals are treated specially and the hash is evaluated at compile time. It's not even necessary to have optimizations enabled.

Severity

Which severity would you assign to this Issue?

  • Gas Optimization
  • Non-Critical
  • Low Risk
  • Med Risk
  • High Risk
commented

Many thanks for raising the Issue! ❤️
I added a warning that this optimization is only valid for solc versions <0.6.12, see this commit.

And please excuse the late response, the notification got lost in my inbox 😢