Missing PyTorch MPS support in CI builds due to older SDK
sbrunk opened this issue · comments
I just gave the macosx-arm64
PyTorch from the CI build a try just to realize that GPU support via MPS is missing. The reason seems that we need a sdk version >= 12.3
but the build is using 12.1
:
if(_macosx_sdk_version VERSION_GREATER_EQUAL 12.3)
set(_MPS_supported_os_version ON)
https://github.com/bytedeco/javacpp-presets/actions/runs/7650509878/job/20880141743#step:2:2541
-- sdk version: 12.1, mps supported: OFF
It also seems like I'm just in time to have missed the release deadline. 🙈
That new version of the SDK is probably available only in macos 12.x right? I'm not going to do that for this release anyway
Yeah it looks like 12.1 is the latest version available in the 11 runner:
https://github.com/actions/runner-images/blob/main/images/macos/macos-11-Readme.md#installed-sdks
Higher versions up to 13.1 will need 12:
https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md#installed-sdks
I've created a branch from current master & the zlib 1.3.1 commit from the release branch and did an update to the macOS 12 runner image to get a first impression of how many presets are breaking.
Looking through the results, we get 4 presets that are failing on macOS 12 (without failing on all other platforms).
- tensorflow
- scipy
../meson.build:80:0: ERROR: Executables created by fortran compiler /usr/local/bin/gfortran-10 are not runnable.
- ngraph
- tvm
Other builds either fail on all platforms (skia and mxnet) or only on linux-arm (seems like a mirror is down) so I'm assuming these are unrelated.
I have a hunch for scipy: gfortran-10
is part for the macOS 11 image, but the macOS 12 image starts from gfortran-11
. I'll try to add It's part of gcc so it will still be installed already with gfortran-10
back in the deploy-macosx
workflow.gcc@10
Perhaps I should also remove gcc-13
?
No, please use GCC 11. Newer versions of GCC tend to be too buggy to be usable. We'll need to update all these lines too:
https://github.com/bytedeco/javacpp-presets/blob/master/.github/actions/deploy-macosx/action.yml#L44-L60
Ah, yes, please remove GCC 13. Are you saving GCC 10 is still available? If that still works that's OK, yes
Yes it looks like GCC 10 just not installed by default anymore in the new image but it can still be installed via Homebrew like it's already done. I'm doing another run with GCC 13 removed.