bvaisvil / zenith

Zenith - sort of like top or htop but with zoom-able charts, CPU, GPU, network, and disk usage

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Improvements to TUI controls

alexmaco opened this issue · comments

How would you feel about making the keyboard controls more in line with other TUI applications?

/ usually means search/filter, in htop, less, vim, etc. However zenith uses this to reverse the sort order in the process table. I think something like ; (or anything else) would be better for reordering, which frees up / to do the usual free that's already in many muscle memories.

Second, after returning from a per-process view, the filtering mode is not active anymore. So before clearing it, to go back one step further to the unfiltered view, one has to press a key to activate it again. I don't know if this is intended for a usecase, so I would suggest either:

  • that filtering stay active if it was active before zooming into a process
  • use a sort of background highlight/inverted view to emphasize the input field for filtering when it is actually active

Thoughts?

Changing filtering to be done via / instead of f is fine by me. I'm not married to the table sort keys.

As for filtering being active, that was intentional - but my memory was hazy. I think the issue was after going back from zooming in on a process that it wasn't immediately apparent that your keystrokes would go into the filtering field. I think emphasizing the input field sounds very sensible to me.

I prefer vim-like keymap too.
Why not add [j/k] to navigate up/down, [h/l] to change sort column instead of [,/.], and '?' to toggle help screen instead of 'h'?
If only there were a configuration file for keymap changes.