Update logging level to 'error'?

[Gordon Chan]

test-collector-ruby/lib/buildkite/test_collector/socket_connection.rb

Line 81 in 1118897

 Buildkite::TestCollector.logger.warn("attempting disconnected flow") 

Should the logging level be error to be consistent with the subsequent lines?

test-collector-ruby/lib/buildkite/test_collector/socket_connection.rb

Lines 88 to 103 in 1118897

     Buildkite::TestCollector.logger.error("attempting disconnected flow") 
     @session.disconnected(self) 
     disconnect 
   end 
 rescue IOError 
   # This is fine to ignore 
   Buildkite::TestCollector.logger.error("IOError") 
 rescue IndexError 
   # I don't like that we're doing this but I think it's the best of the options 
   # 
   # This relates to this issue https://github.com/ruby/openssl/issues/452 
   # A fix for it has been released but the repercussions of overriding 
   # the OpenSSL version in the stdlib seem worse than catching this error here. 
   Buildkite::TestCollector.logger.error("IndexError") 
   if @socket 
     Buildkite::TestCollector.logger.error("attempting disconnected flow") 

[Juanito Fatas]

Yup, good catch! Do you want to make a Pull Request?