Move visinfo inside markup
emaschas opened this issue · comments
For version 3.0 since the structure will be different from version 2.1, why not moving the "visinfo.xsd" inside the markup structure under "Viewpoint" elements (instead of the bcfv filename) ?
This way we get rid of the bcfv files and there is only one xml file to read.
This will also avoid all the code for fetching the Bcfv file related to each Viewpoint.
Something like:
<?xml version="1.0" encoding="UTF-8"?>
<Markup>
<Header />
<Topic Guid="0a36e3d6-97e9-47d6-ab4f-227990429f52" TopicType="Inquiry" TopicStatus="Active">
<Title>Bla bla</Title>
<Priority>Normal</Priority>
<Index>1</Index>
...
<Comments>
<Comment Guid="2b1e79c8-9d2d-419d-887a-fcff8fec7595">
...
</Comment>
<Comments>
<Viewpoints>
<Viewpoint Guid="b496c251-2729-4dee-94a1-085168d36512">
<Snapshot>snapshot.png</Snapshot>
<!-- previously in the bcfv file -->
<PerspectiveCamera>
<CameraViewPoint>
<X>25.11165948911200</X>
<Y>6.27334290868486</Y>
<Z>1.12069185774815</Z>
</CameraViewPoint>
<CameraDirection>
<X>-0.96834420857015</X>
<Y>0.17658870902284</Y>
<Z>0.17642539945909</Z>
</CameraDirection>
<CameraUpVector>
<X>0.17356302090318</X>
<Y>-0.03165121402508</Y>
<Z>0.98431401413660</Z>
</CameraUpVector>
<FieldOfView>70.00000000000000</FieldOfView>
</PerspectiveCamera>
...
</Viewpoint>
</Viewpoints>
</Topic>
</Markup>
The reason for this is that there are different kinds of applications. Some don't care about the 3D content at all.
Application that don't care about the 3D content, can just skip the data or ignore it...
Merging the files will simplify the code to read them and improve consistency between viewpoints and "visinfos".