buildbuddy-io / buildbuddy

BuildBuddy is an open source Bazel build event viewer, result store, remote cache, and remote build execution platform.

Home Page:https://buildbuddy.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[CLI] Queries break for some common attributes

erikkerber opened this issue · comments

Describe the bug

In our .bazelrc we had JDK 11 specified under common:

common --java_runtime_version=remotejdk_11
common --tool_java_runtime_version=remotejdk_11
common --repo_env=JAVA_HOME=../bazel_tools/jdk

When installing the CLI via .bazelversion, queries then broke with an invalid option applied:

ERROR: --java_runtime_version=remotejdk_11 :: Unrecognized option: --java_runtime_version=remotejdk_11

Changing those to build resolves, but it feels like a bug that the wrapper isn't a pure passthrough in this instance

To Reproduce
(Above)

Expected behavior

The wrapper is completely transparent to regular Bazel operations

This is something that we have tracked internally.

Our CLI currently does not understand the new common keyword logic in .bazelrc (since bazelbuild/bazel#18130) and we gonna need to rework our parser to make it happen.

@erikkerber the fix for this is now released in CLI version 5.0.25 - let us know if you run into other issues!