bugsounet / MMM-Pir

Hey, so I wanted to make mode 6 and 7 work but I had issues to get it working. If I'm not wrong there is a Bug in the code here:

Line 307 in 94a72d8

if (responsePy === 1) actual = true;

The if check does a strict comparison with 1 but the type is actually a string. So the fix would be this:

if (responsePy === "1") actual = true

The same has to be done with mode 7

if (responsePy === "0") actual = true;

I tried it locally and it seems to do the trick.
Hope it helps

Hi,

Ah yes, you have right ;)
It's again the result of eslint rules ...
--> can't use ==, Happy use of ===

I correct it or you make a PR ?

Haha oh eslint... I'd suggest using strict string comparison like I wrote above. Seems the more correct way to me

Closing as completed, thanks

Mode 6 and 7 Bug