Chapters 2 and 3 (more minor comments)
ckhroulev opened this issue · comments
I used revision 58a575b.
-
Thus if $Ax=b$ for some $x$ then row $i$ of $A$ is on the rank $m$ processor if and if entry $i$ of $b$ is on the rank $m$ processor.
Should this be "if and only if"?
-
Our $A$ is allocated as dense so the exact LU factorization requires no fill-in.
Define fill-in or provide a reference.
-
to time some bigger solves
Consider saying "some bigger systems". "Solve" is rarely a noun.
-
We can try a direct solve
Should probably say "a direct solver".
-
X11 windows are installed.
Consider saying "if PETSc was built with the X Window System support" (see https://en.wikipedia.org/wiki/X_Window_System).
-
For any nontrivial preconditioner, even one based on diagonal blocks of a tridiagonal matrix as here, different sets of rows ``communicate'' at the preconditioning stage depending on the processor count.
This sentence should probably be re-phrased. (I can't parse it.)
-
significant spectral effect.
Hmm. There must be a better way to say this.
-
$c\rho \partial u/\partial t = - \Div\bq + f$
Add
\,
(c\rho\, \partial...
) to get better spacing. -
i.e.~pass-by-reference
I.e. via an output argument.
-
in the next Chapter we apply a finite element approach
Reference the chapter. (It's not the next one currently.)
-
and we explicitly ask for the \pVec objects to be assembled by calling \texttt{VecAssemblyBegin/End()}
There is no need to do this if you access
Vec
s usingDMDAVecGetArray()
andDMDAVecRestoreArray()
.When
VecSetValues()
is used,VecAssemblyBegin/End()
is needed, though.