Do not hide event titles on calendar pages when using BU Banners, even if a custom title is added to the calendar template page
ashleykolodziej opened this issue · comments
Responsive Version:
2x with BU Banners installed
Expected behavior:
On single event calendar pages, both the banner AND the event title should always show, even if you add a custom title to the banner.
Actual behavior:
On single event calendar pages, the banner shows, but the event title is hidden using the visually hidden class.
Link generated by whatsmybrowser.org:
Affects all browsers.
Link(s) where this can be reproduced:
- https://www.bu.edu/tsai/visit/calendar/ (Banner title is added to this page)
- https://www.bu.edu/tsai/visit/calendar/?eid=254891 (Demonstration of missing event title)
Steps to reproduce:
- Activate BU Banners on a site.
- Ensure BU Calendar is enabled.
- Add a banner, including a custom title, to the calendar template page (main calendar page).
- Visit a single event. It will use the main calendar's banner title, and hide the event title.
Screenshot (if this is a bug):
Related ServiceNow Ticket number (if available):
INC13261584
Related code:
I believe the code that controls this is over here:
responsive-framework/inc/bu-banners.php
Lines 118 to 142 in b8d401f
@ashleykolodziej
There's a list of conditions that need to be true for the class to be applied. I feel the safest way is to add to that check, not to be a calendar event. so: if bla and bla and bla AND not a calendar single give me the hidden class. That way we know it won't effect anything else
Here's a pull request!!!
#273
@aremery if this is closed, please update the tags to remove on dev list and needs resourcing so that we know it is all set.