bu-ist / responsive-framework

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Responsive Activation

mustafauysal opened this issue · comments

bu-site-init.php https://github.com/bu-ist/responsive-framework/blob/develop/bu-site-init.php - the child theme can handle the init instead of the parent

@ashleykolodziej It seems theme-specific initializer strictly tied to the template file. - https://github.com/bu-ist/site-manager/blob/master/lib/api.php#L89

We can use after_switch_theme or plugin activation hook with the custom plugin. However, it can possibly be triggered more than once (let's say you switch theme later on) and raise problems such as deleting the published contents.

IMO, https://github.com/bu-ist/site-manager would be a better home for this functionality.

thoughts?

I think this makes sense. I'm going to see if I can find someone on the webteam to help us out and double check our plan. As long as this is done in a way that only affects Responsive 3x, I think we'll be in good shape. :)

Couple of sites you can test this against:

To test:

  • Switch themes
  • Double check sidebars are the same/have the same widgets
  • Site name, content, etc. should be roughly the same

@ashleykolodziej Thanks for setting up the test sites.

I've cloned them and activated the custom plugin and Responsive Framework 3x

Reference Test Site
http://10up-responsi.cms-devl.bu.edu/flexi/ http://10up-responsi.cms-devl.bu.edu/test-flexi-222/
http://10up-responsi.cms-devl.bu.edu/responsi-1x/ http://10up-responsi.cms-devl.bu.edu/test-responsi-1x-222/
http://10up-responsi.cms-devl.bu.edu/responsi-2x/ http://10up-responsi.cms-devl.bu.edu/test-responsi-2x-222/

I've also created a new website for testing theme initialization (removing default contents, adding menu items etc..) is working as expected. - http://10up-responsi.cms-devl.bu.edu/cleantest/

Let's keep this open till https://github.com/bu-ist/site-manager/pull/11 get merged