btroncone / ngrx-store-logger

Advanced logging middleware for @ngrx/store applications

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[docs] missing imports in readme example

BrainCrumbz opened this issue · comments

Hi

in readme page it seems like the Usage main example is missing a couple of imports, as todos amd visibilityFilter are mentioned, but never imported.

Could you please provide some more info on them?
Thanks!

Sure, these are just sample reducers, their implementation details are not really important. That being said, I can see where it may be confusing for the code sample to not have the proper imports included. I will update this today, thanks for bringing it to my attention!

You're welcome! Especially when one first approaches a library, there are more moving parts and it might be confusing to figure out what is specific to the library and what not. Sometimes it might be enough to add a comment like // ... all standard imports here for general/ standard libraries, and then to only mention the ones specific to the library.