btroncone / learn-rxjs

Clear examples, explanations, and resources for RxJS

Home Page:https://www.learnrxjs.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

need example to make more clear bufferWithTimeOrCount

salisbury-espinosa opened this issue · comments

spec of bufferWithTimeOrCount: http://reactivex.io/documentation/operators/buffer.html
implementation: ReactiveX/rxjs#1556
need an example in order to make more clear the behavior in https://www.learnrxjs.io/operators/transformation/buffertime.html
+
need change signature for bufferTime from

bufferTime(bufferTimeSpan: number, bufferCreationInterval: number, scheduler: Scheduler): Observable

in accordance with
https://github.com/ReactiveX/rxjs/blob/441d52208df8b9247b01f8ca3993e3a7b0870b10/src/internal/operators/bufferTime.ts#L12

Thanks for the feedback and my apologies for the delay. I'll look into updating this in the next few days 👍

Bumping this. Can submit a PR, if interested.

@jankoritak That would be great! 👍

Closing - cleaning up old issues.