$animate.leave no longer accepts callbacks as options on angular 1.4
pdrf opened this issue · comments
Angular 1.4 no longer accepts a callback as an option. (angular/angular.js#11826)
So on deactivate:
function deactivate () {
var deferred = $q.defer();
if (element) {
$animate.leave(element, function () {
scope.$destroy();
element = null;
deferred.resolve();
});
} else {
deferred.resolve();
}
return deferred.promise;
}
should now be:
function deactivate () {
var deferred = $q.defer();
if (element) {
$animate.leave(element)
.then(function () {
scope.$destroy();
element = null;
deferred.resolve();
});
} else {
deferred.resolve();
}
return deferred.promise;
}
This is only valid for version 0.4 I realised now that version 0.5 has this issue fixed so I'm closing this issue.