Deactivating the Modal does not destroy the scope
Francisc opened this issue · comments
Hi,
I changed my modal service to also destroy the scope when the modal window is deactivated.
The scope that gets created when calling activate()
doesn't get killed and is never garbage collected.
Can I make a pull request to fix this?
+1
@Francisc yes
OK, I'll send a PR this weekend.
👍
closed, i presume? :)
Yes.