btford / angular-modal

Simple AngularJS service for creating modals

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Requires template elements

doublemarked opened this issue · comments

The modal currently fails if the template contains no elements (just text).

not sure if it should throw or automagically wrap the elt. thoughts?

I would opt for automatic wrapping.

does it make sense?

modal should be a self contained element, like a window etc - so making it wrap the content makes no sense IMO
how would you even style it? :-)

My head isn't in this problem any more, but @stryju you may be right. Perhaps the proper solution is to throw an exception if there's no element. That is probably a more disciplined approach.

Landed in v0.2.2.

My resolution, by the way, was to throw if there are just text nodes.