btford / angular-modal

Simple AngularJS service for creating modals

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

$scope is not destroyed on close

andreasmpet opened this issue · comments

As far as I can tell, $scope for the controller isn't destroyed when closing the modal.

I might be doing something wrong, but I'm airing the issue anyway.

This example here seems to be explicitly calling scope.$destroy() http://augustl.com/blog/2013/popups_in_angular/ . I can't find a similar call in modal.js

Yeah, that fixed it. I'll put up a PR.

Nevermind. It seems this is fixed in the newest version... Hm, got to check why we're not using that one...