ConsoleAgent passes the path first, which doesn't work with node

[Jordan Harband]

When I try to run my finally tests with test262-harness, passing --hostArgs='--harmony_promise_finally' fails. However, when I edit this line in ConsoleAgent to be args = this.args.concat(args), it passes.

In other words, I think the tempfile path needs to be the last argument passed, at least in node.

[Rick Waldron]

See also: tc39/test262#1156 (comment)

I have a patch written for this, I'm just working out some testing details with @jugglinmike

[Brian Terlson]

I think I also fixed this in the modules branch, fwiw: 6feab85#diff-bdbdfde5f543e4aca41ea83a7b18a3d9R17 (and related functionality).

[Rick Waldron]

My patch is super simple...

(in agents/node.js)

class NodeAgent extends ConsoleAgent {
  createChildProcess(args) {
    return cp.spawn(this.hostPath, this.args.concat(args || []));
  }

[Rick Waldron]

This issue also affects:

• chakra
• d8 (obviously)
• jsc
• jsshell

[Brian Terlson]

@rwaldron this issue is resolved right? I guess "fixes gh-31" doesn't auto-close #31.

[Jordan Harband]

@bterlson #34 isn't merged yet; it will auto-close once it hits master.

[Brian Terlson]

@ljharb ahh right, thanks. Guess that's blocked on making the tests pass.

[Rick Waldron]

Yep, I'm tracking all of this on my end. I just resolved the ChakraCore --debug build requirement, waiting on CI.