Giters

bryankeller / BLKFlexibleHeightBar

Create condensing header bars like those seen in the Facebook, Square Cash, and Safari iOS apps.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Broken indicator insets

kedio opened this issue · comments

commented

I don't know exactly what is happening but the #33 break the indicator insets for my UITableView. If I comment the line in scrollViewDidScroll in BLKFlexibleHeightBarBehaviorDefiner then the indicator insets are as expected.

My setup:
A flexibleHeightBar and a tableView are subviews of a UIViewController
I use autoLayout and all my constraints are define in code

commented

Seems I was setting constraints so my tableView would start just under the FlexibleHeightBar, but it seems it is intended as #33 that the FlexibleHeightBar must overlay the tableView and a contentInset must be set.

_tableView.contentInset = UIEdgeInsetsMake(_headerView.maximumBarHeight, 0.0, GlobalMetrics.LARGE_HORIZONTAL_MARGIN, 0.0)

With this it is working as intended it even fixed some flickering I was experiencing while scrolling. The doc should just be more expressive about this fact.