JavaProxySearchStrategy returns non-null value even though we don't have a proxy based on that.
GoogleCodeExporter opened this issue · comments
Google Code Exporter commented
What steps will reproduce the problem?
1. Have a IE proxy - pac file or otherwise.
2. Have System.getProperty("http.proxyHost") return null;
3. In proxy-vole version 110515 we return null and we continue looking at other
strategies but in 111102 we don't return null thus subverting other strategies.
What is the expected output? What do you see instead?
Valid proxy servers based on PAC file setting. But instead I get no proxy
server.
What version of the product are you using? On what operating system?
111102. Windows 8.
Please provide any additional information below.
We used to return null in 110515 in getProxySelector() if host is null, this
got changed in the newer version.
Original issue reported on code.google.com by gopinath...@gmail.com
on 15 Aug 2012 at 3:05
Google Code Exporter commented
Please use the attached file for testing.
Original comment by gopinath...@gmail.com
on 15 Aug 2012 at 7:23
Attachments:
Google Code Exporter commented
i have been facing the same problems.
Will this bee fixed soon?
Original comment by goran.sc...@gmail.com
on 4 Sep 2012 at 9:00
Google Code Exporter commented
Hi,
I fixed this issue and have build a new version, Please download: proxy-vole
20120905
and give it a try. Now if http.proxyHost property is not set then the
JavaSearchStrategy will return null and therefore will not be used.
As a side effect this means if you only set for example the ftp.proxyHost but
not the http.proxyHost it will not be used.
But this was the best way of implementing it.
Have fun,
- Rossi
Original comment by rosstaus...@googlemail.com
on 5 Sep 2012 at 9:57
- Changed state: Fixed
Google Code Exporter commented
Thanks for the fix. I'll test it later this week :)
Original comment by goran.sc...@gmail.com
on 5 Sep 2012 at 10:12
Google Code Exporter commented
This seems to work now!
Thanx
Original comment by goran.sc...@gmail.com
on 6 Sep 2012 at 6:01