brikis98 / docker-osx-dev

A productive development environment with Docker on OS X

Home Page:http://www.ybrikman.com/writing/2015/05/19/docker-osx-dev/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Brew Cask dependency shouldn't break installation

ain opened this issue · comments

If Brew Cask isn't used on any of the dependencies, it shouldn't be a breaking dependency?

Hm... It used to be a requirement to install VirtualBox. However, at some point, the brew_install call for VirtualBox disappeared. Is it installed by something else?

VirtualBox was removed in 56edcdb by PR #55.

Generally, VirtualBox is also part of Docker Toolbox that delivers most of the dependencies.

@tsupertramp was there a particular reason why you removed VirtualBox from the dependencies?

I'd actually rather have it in there as we have everything else. The original implementation does make sense.

Considering the feedback from other topics, Brew Cask dependency should be restored.

@ain @brikis98 what's the verdict here re: VirtualBox as a dependency? The project README only lists Homebrew as a prerequisite. We should either add VirtualBox/Docker Toolbox there or add VirtualBox back to the brew dependencies.

Usually, the goal is to put as little into docker-osx-dev as possible. If docker-toolbox installs most of what we need, we should use that, let it handle the details, and remove the rest.

I agree with @brikis98 since Docker Toolbox delivers:

  • Docker Engine
  • Docker Machine
  • Docker Compose

I'd propose removing all functions that try to install them and have a dedicated Requirements section in README instead.

VirtualBox should just make a separate bullet point in README.