brianleect / etherscan-labels

Full label data dump of top EVM chains in JSON/CSV.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Bug] Table address column name, accounts != tokens

brianleect opened this issue · comments

commented

Seems that for tokens the column name for address if Contract Address while for accounts it is Address . Not sure if this was a recent change. Unable to test running on etherscan atm due to cloudflare blocking however visually it appears that its the case.

Simple fix: Change from df.address to df['Contract Address'] for token field
Better fix: Loop through first role and dynamically determine name at runtime via checking field with address

commented

Alternative soln is to hardcode index so we aren't dependent on column name changes only relative positioning. It's likely that position of address is unlikely to change