Test suite depends on activerecord version

Question

Test suite depends on activerecord version

pic opened this issue 9 years ago · comments

it is green with activerecord 4.0.13,
1 failure with activerecord 4.0.8,
6 failures with activerecord 4.2.0 (but union apparently works without problems).

Different versions of activerecord build different SQL statement, but the test suite is comparing #to_sql to an expected SQL string.

I have no idea how this could be easily fixed.

Brian Hempel · Answer 1 · Thu Mar 19 2015 22:18:42 GMT+0800 (China Standard Time)

All such problems have solutions. Bug me in a week if I haven't gotten around to fixing it yet.

Brian Hempel · Answer 2 · Mon Mar 30 2015 09:38:18 GMT+0800 (China Standard Time)

I updated the tests to match Rails 4.2 output. I am not so concerned about older AR versions since the function of the gem is unchanged.