modify qname

Question

modify qname

ruqianl opened this issue 5 years ago · comments

ruqianl commented 5 years ago

Hi Brent,

I'm wondering if there is any easy way to modify a record.qname as I would like to add additional information to it.

Cheers,
Ruqian

Brent Pedersen · Answer 1 · Fri Jul 12 2019 21:34:57 GMT+0800 (China Standard Time)

I agree this would be nice to have. But, it is actually not trivial as it requires updating the entire bam record. You can see how pysam does it here
I would gladly accept a PR for this. If not, I will have a look soon.

Brent Pedersen · Answer 2 · Sat Jul 13 2019 01:19:17 GMT+0800 (China Standard Time)

I went ahead and added this as set_qname(r:Record, qname:string)
please let me know any problems. Thanks for the suggestion.

ruqianl · Answer 3 · Sun Jul 14 2019 11:04:01 GMT+0800 (China Standard Time)

Thanks for that, I tested that add it works well!