brendt / rfc-vote

A community project for voting on PHP RFCs

Home Page:https://rfc.stitcher.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

🎨 Redesign the about page

SerhiiCho opened this issue · comments

commented

I want to redesign the about me page since there are now contributors added to it 🤔 I'll post WIPs to get the feedback

Blocked by #205

Go for it :) #205 is now merged :)

commented

Is the word "Focus:" okay for highlighting the things that contributors are worked on? Maybe we just remove it so that we don't have to keep track of these things? Maybe it's better to just make it as 'backend' and 'frontend'? I like the option with 'backend' and 'frontend':

image

My 2ct, I would remove word Focus and make the contributions different color, maybe gray-ish. Also, perhaps it would look tidier if the blocks were fixed width? Or maybe even fixed width, but alternate the count and offset in each row, so it looks like masonry brick effect?

Yeah, I don't think we need focus, I think it's clear on its own?

Where do you get the avatars from? GitHub?

Oh, random idea, we could link contributors to users on the app, also showing their reputation, etc. I can work on that once you're done with the redesign :)

commented

I personally don't like the aligned version. I like when it's more mixed up, but it looks decent

Screenshot 2023-08-31 at 10 49 27

commented

I can even make 4 columns like this:

image

The problem is that some people have long usernames

I like the look of the text!. I guess no matter how big the block is, someone could add a super long name just for the sake of it. But since this is coming from the json file in the repo, there's more control over it?

commented

also showing their reputation

Great idea, it means that we can even pull avatars from out storage instead of using github ones. It would be nice to make them link to to profiles instead of github profiles but I don't think about the reputation. It's kinda hard to gain it, whoever makes first arguments gets the most upvotes. For example, I've created arguments late when most people already upvoted everything and there is no way to gain the reputation. I don't know, it's up to you @brendt, it might be good

commented

I think it now looks good. I've made a condition for the name:

mb_strlen($c->name) > 10 ? 'text-xs' : 'text-sm'

The only long name here is 'Ngô Quốc Đạt` and it looks good with small font:

image

It's kinda hard to gain it, whoever makes first arguments gets the most upvotes.

Well, it needs balancing, we'll improve it over time. But the system itself should play an important role. No worries though, we can improve on it later, it doesn't need to be present on this page just yet.

Looks great, btw! I think I like the aligned version slightly more, but that's just personal preference.