User flair for core php-src maintainers
olleharstedt opened this issue · comments
Some users' opinion on internal technical matters might weigh heavier than others. :) If I say "generics is possible to implement in the PHP engine" it doesn't mean much, because I'm not a core php-src maintainer. To highlight technical expertise during discussions, some users could have verified badges next to the user name, like "core PHP maintainer". Other labels might be relevant too, for framework maintainers, extension maintainers, people with voter rights, etc.
This is similar to certain subreddits where users can be verified as professional doctors or historians.
The user should probably be able to change which verified label to show or hide at any point.
I like that idea, makes a lot of sense! It's related to #51, but I like this approach more. I would make the flow a bit simpler than Reddit's though:
- Users can apply for verification via their profile page, they should simply write a motivation which badge they should get, and why
- Admins have a screen that lists all verification requests, and can grant or deny them.
- The admin should pick or write the correct flair, and pick a color as well.
I think this is a great idea. I guess that some of this validation steps can also be automated in some ways, like framework maintainers there has to be some ways to get this info from github api.
As I'm thinking more about this, I fee that we do need to implement some sort of validation process and have some sort of verified badge, think of it as a general validation badge and I think it can be easily implemented.
What if we consider github as some sort of verification processor, what I mean by that is that any user registered with github it is automatically validated/verified, users who registered through the web form have a button somewhere to link their account with github.
I think in the end, what I'm saying is that users will not be able to just simply paste a link to a github profile, they actually have to link their account with github, in this way I know for sure that the user actually owns that github account.
Verifying with GitHub was actually the exact idea I was thinking about as well. I'm gonna focus on the special badge case first, and then work in automation.
WIP in https://github.com/brendt/rfc-vote/tree/user-flair
TODO:
- Finish the TODO paragraph in the profile form
- Style the flair itself
- Maybe we need predefined flair color sets for foreground and background, so that you don't have to pick a random hex
@SerhiiCho do you have any input?
Sure
I would have been nice instead of adding flair and flair_color columns, add flairs table with all the needed flairs data. Also flair_user table to connect user and flair. I would have been better in the long run.
Because if we change flair color, we'll need to change this color for every user that already have flair_color assigned to them.
As for flairs table, I would add id, type and color columns. For type, we'll use a PHP enum of course. What do you think @brendt ?
Great idea. Maybe it's ok to keep them in an enum though? I don't think we need to make them dynamic, as there will only be a handful of flair types in total.
Do you perhaps also have an idea about how we can style flairs in the argument cards?
Do you perhaps also have an idea about how we can style flairs in the argument cards?
Yeah, I would personally go for a colorless version like this:
I am not convinced that, whether a user is an admin or PHP contributor, they need to be associated with some color. Similar to what GitHub has:
I would also drop "Read the " from this line in the footer:
Makes sense, I like it! Do you want to submit a PR?
It's done :)
For now, admins, contributors and internals can apply for a badge.
Hooray!