breamware / sidekiq-batch

Sidekiq Batch Jobs Implementation

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Skips on_success callback for some batches

rudrakshi2014 opened this issue · comments

While running multiple batches simultaneously, on_success callback is being skipped for few batches.
In sidekiq logs, there are no logs saying DEBUG: Finalize success batch id: for the respective batches.
No issue noticed with on_complete callback.

It is similar issue as of:
#32 (comment)

It is marked as closed but yet not resolved.

also been facing this issue recently. unable to find reproducible situation

Was this only happening when a job succeeded after a failure (a retried job)? I added a PR (#43) that addresses #32 from what I saw happening.

Jobs were not failing but yet on_success calls were missing. The pattern I noticed was, these jobs are of same worker class.
Thanks @davidrichey for adding the fix for #32 (comment)

Interesting. We have around ~1300 batches running a day and haven't seen this yet. Only errors we had we when a job failed, retried & succeeded and the on_success callback wouldn't run

Stale issue message