Giters

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.

Home Page:https://brave.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[iOS] Leaking history in private mode

jikkuatwork opened this issue · comments

commented

Description:

I use Brave iOS in permanent private mode. I recently noticed that one link which I opened appeared in bookmarks/history while trying to use address bar! I can't even clear the history as there is no option to do it as I am in private mode.

Steps to Reproduce

I opened this link from WhatsApp. The link is just a product hunt standard link. Its not happening with any other links.

Actual result:

https://twitter.com/jikkujose/status/1788893781858857198

Expected result:

Brave should be have like an ephemeral portal to Internet that refreshes to new (while in private mode) during app restart.

Reproduces how often:

Unable to reproduce.

commented

Hey @jikkuatwork we are having problems reproducing it.

Are you sure you did not visit this link in regular browsing mode, then switched to private-only at some point later?
I ask because in private mode we display history entries for urls visited in regular mode, before you switched to the private mode

Other theory would be this is a synced history item from another device?

commented

Over the past 3 years since I had this phone, I never once used Brave outside private mode. I am 100% sure it never got switched in between.

I have never synced any of my browsers in any of my devices.

Its so bizzare that this was still showing up in my phone despite there is no entry in History! Anyways, I just reinstalled the app & it went away.

(Please try to never change this feature. Its so good to have a purely temporary instance of browser to search & just exit the app to remove all the history instantly)

commented

It does not show in the history panel because we show nothing if the private mode flag is enabled.
For search suggestions though we show history entries from regular mode there.
So this url must have leaked into regular mode somehow.

So far we were not able to reproduce, I will update this ticket if there's more findings.
If you or anyone else is seeing this problem and is able to reproduce it consistently please let us know

Private only browsing mode is a niche feature but i did not hear plans of removing it :) We plan to add easier way to delete browsing data in regular modes: forgetful browsing mode and maybe some easy access button to quickly wipe browsing data

commented