brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.

Home Page:https://brave.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[NTP Search]: Enable NTP search by default in Nightly

fallaciousreasoning opened this issue · comments

Description

Flip the switch brave://flags/#brave-ntp-search-widget and enable by default in Nightly channel.

Blocking issues

Tasks

  1. OS/Desktop QA/Yes release-notes/exclude
    fallaciousreasoning

Related Issues

Figma link: https://www.figma.com/design/lVTufBkl5eNrtOQjlAHxjb/Search-box-in-NTP?node-id=220-17509&t=r4vAQxbMdJ6n8sKZ-0

Main issue: #35535

#38303 fixes the UX bugs

Okay @rebron there are a couple of PRs and I think we can flip the flag

Some notes on visual polish

Initial state

image
  • There's a weird second glass effect above the search input
  • Icons (carat-down and search icon) should have a glass/50 color
  • Removed the outline on the dropup for engine selection, and added a divider. Cleans up the view a bit
  • Placeholder text should be glass/70 and use font/large/regular
  • The whole search input doesn't use a regular divider, uses a custom one called strokegradient/dark
  • The dropdown to change engines doesn't open in the closed state. When I click on it, it opens the full thing instead of the dropdown

Autosuggestions

image
  • Search term is black, should be glass/100
  • Search icons on the left shouldn't have a square background, and the color is glass/50
  • If we can divide the "Ask Leo" item like on the design, that'd be ideal
  • General stroke is the same as initial state, strokegradient/dark
  • Need to add a close button when the input text is entered to clear the box
  • Link previews beneath results is glass/70