brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.

Home Page:https://brave.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Button text cut off on dialog when in split view [Phone]

Uni-verse opened this issue · comments

Description

Button text is cut off when Multiple windows detected dialog is shown in split view.

Related to: #38203

Steps to reproduce

  1. New install
  2. Set Enable multiple windows to ON in Appearance settings
  3. Go back to new tab, long press on favorites and select Open in new window
  4. While in split view, open menu in either one of the windows and turn Enable multiple windows toggle to OFF in Appearance settings
  5. Observe dialog

Actual result

Button text is cut off. Should probably be stacked or dialog should be expanded.
Screenshot 2024-05-13 at 11 00 24 AM

Expected result

Screenshot 2024-05-13 at 11 00 43 AM

Issue reproduces how often

Always

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? No
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung GS21
  • Android version: 13

Brave version

1.66.105

The above requires 1.66.10 or higher for 1.66.x verification 👍

Verified on Samsung Galaxy S21 using version:

Brave	1.66.110 Chromium: 125.0.6422.60 (Official Build) (64-bit) 
Revision	de593d76e2ca4d02faa85bf1ca27bcf3ee46793c
OS	Android 13; Build/TP1A.220624.014; 33; REL

New Users

  1. New install
  2. Set Enable multiple windows to ON in Appearance settings
  3. Go back to new tab, long press on favorites and select Open in new window
  4. While in split view, open menu in either one of the windows and turn Enable multiple windows toggle to OFF in Appearance settings
  5. Observe dialog

Existing Users

  1. Install 1.65.133
  2. Upgrade to 1.66.110
  3. Set Enable multiple windows to ON in Appearance settings
  4. Go back to new tab, long press on favorites and select Open in new window
  5. While in split view, open menu in either one of the windows and turn Enable multiple windows toggle to OFF in Appearance settings
  6. Observe dialog
  • Ensured button text dialog visibility is improved from the previous version.
  • Ensured Merge windows and Close windows buttons are working.
Example Example
Screenshot 2024-05-16 at 10 29 25 AM Screenshot 2024-05-16 at 10 32 23 AM