create a new branch for the Chinese version

Question

create a new branch for the Chinese version

madneal opened this issue 7 years ago · comments

I am interested in your awesome work. And I want to create a new branch to translate this tutorial into Chinese. Will it be allowed?
Thanks.

Brannon Dorsey · Answer 1 · Tue Aug 01 2017 22:36:57 GMT+0800 (China Standard Time)

This would be amazing! I will absolutely merge it 👍 How about README.zh.md and appendix.zh.md?

Neal Caffery · Answer 2 · Wed Aug 02 2017 06:55:54 GMT+0800 (China Standard Time)

So I would create the branch named ch which will contained the files you mentioned. Will it we OK?

Brannon Dorsey · Answer 3 · Wed Aug 02 2017 06:57:01 GMT+0800 (China Standard Time)

That sounds great. And then I will merge your branch into master and link to them from the English version as well. Thank you!

Brannon Dorsey · Answer 4 · Wed Aug 02 2017 06:57:35 GMT+0800 (China Standard Time)

Please let me know if I can help you in any way by answering questions etc.

Neal Caffery · Answer 5 · Thu Aug 03 2017 20:39:00 GMT+0800 (China Standard Time)

The pr has been proposed, any problem, please tell me directly.

Brannon Dorsey · Answer 6 · Fri Aug 04 2017 12:27:55 GMT+0800 (China Standard Time)

Thanks so much for this contribution. I've merged into master and linked/offered thanks to you in the README.md. If you would like to include those changes in the Chinese versions I will accept another PR. I greatly appreciate your efforts in this endeavor. It's exciting to have this text translated!