brandly / angular-youtube-embed

:tv: Embed a YouTube player with a simple directive

Home Page:http://brandly.github.io/angular-youtube-embed/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Webpack integration

okhomenko opened this issue · comments

Package doesn't work with webpack.
On build it throws

WARNING in ./~/angular-youtube-embed/src/angular-youtube-embed.js
Critical dependencies:
1:16-23 require function is used in a way in which dependencies cannot be statically extracted

here's when the require was added. @konsumer might want to give his input on how best to handle this, since we were under the impression this would work with webpack, but maybe we never tried it out hahah

Yes, now it works fine with webpack. Previous code could work with systems which don't do static analysis (not sure if there are any).