braincrafted / bootstrap-bundle

BraincraftedBootstrapBundle integrates Bootstrap into Symfony2 by providing templates, Twig extensions, services and commands.

Home Page:http://bootstrap.braincrafted.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

ScriptHandler fails to install glyphicons in Symfony 2.5

atosatto opened this issue · comments

The ScriptHandler should be updated to support the new location of the Symfony console in Symfony 2.5.

I think is sufficient to update the $appDir variable initialization in the install function.

https://github.com/braincrafted/bootstrap-bundle/blob/develop/Composer/ScriptHandler.php#L33

Is there a config option I can use that gets me the location of the Symfony console in Symfony < 2.5 and >= 2.5?

This is how I solved it in the SpBowerBundle.
Spea/SpBowerBundle#86

Use the symfony-bin-dir if it exists, else fall-back to using the 'old' appDir.

Edit. Oops, it should be, use the symfony-bin-dir if it exists (not symfony-app-dir).

I'll open a PR today to fix this.

@Stok - I was already preparing the PR. :)

No problem ;)