Submit button is grayed out
ZevEisenberg opened this issue · comments
Version 0.1.1 from the Releases page.
Should this be working?
In this case it's because you have to have something in all fields right now. This means Configuration and notes at least need a space. I'm not sure the best way to handle this moving forward.
Oh hey, that totally worked. I thought I had tried that, but I guess not. I don't even know what goes in "Configuration." Some hint text would be nice. But if they're all required, maybe just substitute spaces in if you leave fields empty?
I don't think any fields here are actually "required", the original reason I made them all required was just to sanity check your submissions. Not sure what the best approach is here. I could definitely add the placeholders as a step 1 though.
I'd like to bump this from a question to a feature request: It should be possible to submit a radar with only one of the main fields filled. It may make sense to ask when clicking ’Submit‘ without having everything filled out, but it should be able to still submit. Reason: When submitting feature requests / enhancements, there often are no steps to reproduce and maybe even no actual behavior.
To sanitize the input a little bit though I propose that at least the title and the description field need to contain some text, as I can't come up with a reason that makes sense to leave these empty. But maybe there are?
It looks like on Radar web the only option fields that we have that are currently non-optional are Configuration and Notes. I think we might want to mirror this behavior.
Thoughts?
Also note that for duping the optionality of fields doesn't affect the ability to submit since I fill all other fields with a single space. That's kind of a nasty work around but I think it's nicer for UX.
Done in #86
Also note that for duping the optionality of fields doesn't affect the ability to submit since I fill all other fields with a single space. That's kind of a nasty work around but I think it's nicer for UX.
That's no longer necessary now though, right? Does #86 fix that as well?
Only for those 2 fields yea. I removed the singles spaces for those fields for duping in #86 https://github.com/br1sk/brisk/pull/86/files#diff-a021e3fdf04516435e903458188d120bR44