Do not run some tests if not run with a TTY

[Sebastian Ramacher]

Forwarding a bug report from Debian (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=806480). Looks like some tests fail with closed stdin and if stdout is redirected to a file. Could this tests be protected with some kind of check?

[Tom Ballinger]

If this produced the same environment,

import sys
import nose

if __name__ == '__main__':
    sys.stdin.close()
    sys.stdout.close()
    nose.run()

then thomasballinger@5384f45 should fix it.

[Tom Ballinger]

This is in a released version now because I needed to release for the FtmStr equality bug FYI

[Justin Lecher]

I see the failing test with version 0.2.4 and this patch.

[Tom Ballinger]

Ah rats. I assume 0.1.21 is failing in the same way? That's the one I was trying to fix, but I assume results would be the same with 0.2.4 and the patch applied.

@jlec or @sebastinas, could you point me to how to run these tests in this way? Or happen to know how to mimic whatever aspect of these conditions is causing the failures?

[Sebastian Ramacher]

It seems the tests are run with something like nosetests </dev/null. That's enough to reproduce the problem in the 0.1.x branch.

[Justin Lecher]

In Gentoo we are running python setup.py build, set PYTHONPATH to the newly build files, and run nosetests --verbose tests.

[Tom Ballinger]

Doing a sys.stdin.isatty check now, was silly of me to assume that stdin would be closed at the Python level. Fixed in both 0.1.x and master, no releases yet.

[Tom Ballinger]

This has been released as curtsies-0.1.22, and curtsies-0.2.5

[Justin Lecher]

For both versions I see

======================================================================
ERROR: test_array_from_text (test_window.TestBaseWindow)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/tmp/portage/dev-python/curtsies-0.2.5/work/curtsies-0.2.5/tests/test_window.py", line 42, in test_array_from_text
    a = window.array_from_text('.\n.\n.')
  File "/var/tmp/portage/dev-python/curtsies-0.2.5/work/curtsies-0.2.5-python2_7/lib/curtsies/window.py", line 79, in array_from_text
    return self.array_from_text_rc(msg, rows, columns)
  File "/var/tmp/portage/dev-python/curtsies-0.2.5/work/curtsies-0.2.5-python2_7/lib/curtsies/window.py", line 86, in array_from_text_rc
    if i >= rows * columns:
TypeError: unsupported operand type(s) for *: 'NoneType' and 'NoneType'
-------------------- >> begin captured logging << --------------------
curtsies.window: DEBUG: -------initializing Window object <curtsies.window.BaseWindow object at 0x7fd3f29ad190>------

[Tom Ballinger]

@jlec There's now a 0.1.23 and a 0.2.6, is it fixed in these?

[Justin Lecher]

There's now a 0.1.23 and a 0.2.6, is it fixed in these?
Works perfectly.