Arrow keys don't work in popup menu

Question

Arrow keys don't work in popup menu

smbea opened this issue 2 years ago · comments

Beatriz Mendes commented 2 years ago

Describe the Bug

Arrow keys don't work in popup menu when search is turned off

Steps to Reproduce

Steps to reproduce the behavior:

Screen.Recording.2022-11-21.at.09.56.30.mov

open popup menu for sub process
use arrow up/down
see that element moves instead of navigating the menu

Expected Behavior

The arrow keys should result in menu navigation

Environment

Please complete the following information:

Library version: 11.0.0

Beatriz Mendes · Answer 1 · Mon Nov 21 2022 20:41:40 GMT+0800 (China Standard Time)

Cause: This happens because the keyDown listeners were added to the search input when it is focused. Causing this to be lost when the search is not rendered

Possible solution: Attach listeners to menu itself and not search input

Nico Rehwaldt · Answer 2 · Tue Nov 22 2022 05:23:12 GMT+0800 (China Standard Time)

Further root causing:

adding tab-index=-1 to the popup menu allows us to focus it programmatically
HOWEVER: Keyboard will always use the capture phase to intercept events; as a result we cannot hook in before it 🙈

Some work-in-progress fix for this is part of #706

Beatriz Mendes · Answer 3 · Tue Nov 22 2022 19:34:27 GMT+0800 (China Standard Time)

We want to solve #707 before this, since it affects how this bug is solved.