Trying to reference non-existent facts
jamieconnolly opened this issue · comments
Inside init.pp
, we're checking for the existence of the gname
and gemail
facts before setting them as the relevant git configuration values. Looking through the main boxen repositories, it seems like these facts don't get set. Should they be referencing the github_name
and github_email
facts?
# manifests/init.pp:#L60-L70
if $::gname {
git::config::global{ 'user.name':
value => $::gname
}
}
if $::gemail {
git::config::global{ 'user.email':
value => $::gemail
}
}
The code is here.
I'm more than happy to create a PR for this if needs be.