support tags in configuration file
linbo opened this issue · comments
Hi,
Since for most cases, metrics are already predefined in different groups, init metrics with tags is preferred.
I think can folsom support tags in configuration file? for example
$ echo '[{folsom, [{history, [{hist1, [tag1, tag2]}, {hist2, [tag2, tag3]} ]}, {gauge, gauge1}]}].' \
> myapp.config
$ erl -pa ebin deps/*/ebin -config myapp.config -s folsom
The init code changed as flowing:
configure_metric(New, Spec) when is_list(Spec) ->
apply(folsom_metrics, New, Spec);
configure_metric(New, Spec) ->
case Spec of
{Name, Tags} ->
folsom_metrics:New(Name),
[folsom_metrics:tag_metric(Name, Tag) || Tag <- Tags];
Name ->
folsom_metrics:New(Name)
end.
If accept, can I send a pull request?
Folsom has moved, please resubmit your issue at https://github.com/folsom-project Thanks!