VSS-01C: Data Location Optimization

[Klemen]

VSS-01C: Data Location Optimization

Type	Severity	Location
Gas Optimization	Informational	VoucherSets.sol:L182, L183, L184, L216, L217

Description:

The linked arguments are declared as memory in external functions.

Example:

function mint(
    address _to,
    uint256 _tokenId,
    uint256 _value,
    bytes memory _data
) external override onlyFromVoucherKernel {
    _mint(_to, _tokenId, _value, _data);
}

Recommendation:

We advise them to be set as calldata optimizing their gas cost.