borkweb / BootstrapMediaWiki

A MediaWiki skin using Bootstrap 4 & FontAwesome 4

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

mw-headline span in h2 is hiding links

poikilotherm opened this issue · comments

Hey guys,
I just noticed the following bug in Firefox 31 and Chrome 33 (both on Linux), as you can see in the screenshot:

bootstrap-span-hiding-links

The green area is caused by padding-top:128px and thus rendering the links useless. Actually, I don't really understand why there is a padding-top:128px and a margin-top:-128px...?

In 4b068f2, fixes forjumbotron were introduced, adding the padding/margin stuff to the css class.

.mw-headline {
        margin-top: -128px;
        padding-top: 128px;
        text-shadow: 1px 1px 0 rgb(255,255,255);
}

If I comment out these two, links on the page are working again as the box is not oversized anymore. Don't know what this breaks and why this was introduced in the first place?

Just another thing: in #20, there where z-index css attributes assigned to id m-content-text > * and > h2/h3/...

This is working for > * (all the stuff gets z-index: 2), but not for h2/..., as these elements are reset back to auto, not 1! This is also the case for the surrounding < div > with class col-md-X.

That margin/padding weirdness was an attempt at a non-JS solution to prevent in-page-anchors to be hidden by the fixed nav bars when navigated to on the page (from the TOC sidebar, for example).

I've reverted the margin/padding fix and will dig into a different solution for the anchor issue.

In the mean time, this revert should resolve this ticket and I've reopened the TOC issue.