Support specifying id attribute for button objects
ronan-paul opened this issue · comments
Hello
Having an id attribute for button objects is a major need for test automation (which is why this new request duplicates #598 which has been closed).
Here is why it is needed
- select elements (like buttons) with their id so that there is no risk of ambiguity
- using a specific class looks like an easy workaround, but it is not semantically correct, because:
-- a class name is supposed to be related to the design
-- multiple elements might have the same class name, by definition of a class
So I would propose this to be implemented with either:
Option 1 - create an optional id property for each button
bootbox.dialog({
title: 'FullScreen ',
message: '<p>Do you want to go for fullscreen</p>',
buttons: {
cancel: {
label: 'Oh no',
id: 'dialog-fullscreen-btn-cancel', //new property
className: 'btn-primary',
callback: function(){
//whatever
}
},
accept: {
label: 'Go for it',
id: 'dialog-fullscreen-btn-accept', //new property
className: 'btn-info',
callback: function(){
//whatever
}
}
}
})
Option 2 - use button key as id property (less compliant with current semantic of bootbox IMO)
bootbox.dialog({
title: 'FullScreen ',
message: '<p>Do you want to go for fullscreen</p>',
buttons: {
dialog-fullscreen-btn-cancel: {
label: 'Oh no',
className: 'btn-primary',
callback: function(){
//whatever
}
},
dialog-fullscreen-btn-accept: {
label: 'Go for it',
className: 'btn-info',
callback: function(){
//whatever
}
}
}
})
Any version would create these 2 buttons :
<button id="dialog-fullscreen-btn-cancel" type="button" class="btn btn-primary">Oh no</button>
<button id="dialog-fullscreen-btn-accept" type="button" class="btn btn-info">Go for it</button>
This improvement would allow automation tests to run with specific selector like:
$I->click('#dialog-fullscreen-btn-accept');
and no longer:
$I->click('button[title="Go for it"]');
or
$I->click('button.my-button-class');
Thank you in advance
This is supported in v6, which is a work in progress - https://github.com/makeusabrew/bootbox/blob/v6-wip/bootbox.js#L305
I won't be backporting this to v5, so it's up to you how comfortable you are with testing a WIP/beta version.
@tiesont sounds great !
I am open to WIP... but may I ask how advanced is this v6 ?
PS: I think it would also be good to have an id set for the modal itself, with the same goal and benefits.
@tiesont sounds great !
I am open to WIP... but may I ask how advanced is this v6 ?
PS: I think it would also be good to have an id set for the modal itself, with the same goal and benefits.
The test suite has been updated to test the modals against both BS4 and BS5, and everything passes, so it's probably safe to try updating your code. I just haven't really exercised the v6 version with much hands-on testing yet, hence why it's still labeled as a WIP.
The test suite has been updated to test the modals against both BS4 and BS5, and everything passes, so it's probably safe to try updating your code. I just haven't really exercised the v6 version with much hands-on testing yet, hence why it's still labeled as a WIP.
Is it also still BS3 compatible ?
Most likely, yes. Modal markup hasn't changed too much. The main issue is that not all options will work, but that's always been the case.
I might try adding tests for BS3, but it depends on free time and motivation, so who knows.
The test suite has been updated to test the modals against both BS4 and BS5, and everything passes, so it's probably safe to try updating your code. I just haven't really exercised the v6 version with much hands-on testing yet, hence why it's still labeled as a WIP.
Is it also still BS3 compatible ?
Hello,
I did include the latest bootbox.js (v6-wip) in my project which runs on BS3.3.
Everything looks quite smooth and working. Kudos.
A few remarks:
- I tried to add a default value for size in the defaults object, but it has not been taken into account.
- Any "medium" size available ?
- I wish I could also set an id for the dialog, so that I can also check if a specific dialog is being shown (whatever its label are).
=> Is that also possible to implement ?
I will run some additional tests and give you feedback of course.
Regards,
Ronan
Any "medium" size available ?
No. "Medium" would be a normal-sized modal, so that size would serve no purpose - hence why it doesn't exist in Bootstrap. The size options are all used for setting these.
I wish I could also set an id for the dialog
I'd rather not. There is both an onShow and onShown option for which you can set a callback function.
I'll look into the size thing - if that isn't working, then it never has. I don't remember if we ever intended to, but size was a relatively late addition to the codebase.
I suppose I can look into it. I make no promises, though.
Closed in #820