vscode workspace was added to the repository
mattpap opened this issue · comments
In commit 88b5477, which doesn't look like a mistake. Why? I don't see a reason to keep private configuration in the repository. vscode allows to store workspaces outside of a repository.
It was not a mistake. I want a place for it to live that is easily clone-able. I can't stress enough that although you consider these to be private configuration, that is an opinion. Many projects offer workspace configurations as a convenience to users/developers as a means to help people get on the same page quickly. I want to do the same for us. I would even like to encourage (or at least mention) the workspace explicitly in the contributor guide, because vscode is by far the most popular IDE and we should meet users where they are. [1]
I am open to other places but I insist that:
- it be public under the Bokeh GH org
- we not create an entire repo solely for this purpose
Putting it in this repo, specifically, was already my compromise for not putting it in the main repo (which I do think would be preferable), because I know you would object strenuously to that.
[1] I also realize that a vscode workspace configuration may not interest or apply to you, personally. That's fine, not everything has to—you can just ignore it .