bnzk / djangocms-misc

customizing django and django-cms to my likes

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

untranslated placeholders: ensure they plugins always have the same language!

benzkji opened this issue · comments

otherwise we'll face tree errors when sorting.

  • use a pre_save signal for cms_cmsplugin creation?
  • OR: rethink untranslated placeholders, as fallbacks, that are always shown (less complex monkey patching!!!).
  • ordering plugins when in other than the plugin's language is generally a problem, as the placehoderadminmixin does some checks - another monkey patch, for move_plugin (adapt placeholder_id, and call the original...) https://github.com/divio/django-cms/blob/release/3.4.x/cms/admin/placeholderadmin.py#L667

editmode_fallback is preferred, so editors can still override some placeholders...no action for now