bnb-chain / node

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

ERROR: no Ledger discovery function defined

UniversalGlow opened this issue · comments

(similar as this never resolved issue: bnb-chain/node-binary#77)

Just downloaded latest (v0.10.14) MacOs Binary from https://github.com/bnb-chain/node/releases.
Got ERROR: no Ledger discovery function defined whenever I try to interact with Ledger hardware through bnbcli

Command : ./bnbcli keys add binance_keys --ledger --index 0 --account 0
Output in Terminal: ERROR: no Ledger discovery function defined

Does this binary not support Ledger ? Do I need to build from code and include some flags to add Ledger support?

Please advise.

PS:
In the past - the only version that actually works with Ledger is v0.6.0 - coincidentally (or not) the only version where it that has an entry stating [\#571](https://github.com/bnb-chain/node/pull/571) [CLI] make bnbcli to support ledger in the CHANGELOG

After doing some more digging I guess the issue is as stated in a 2018 changelog:

LEDGER_ENABLED true by default except when cross-compiling

So I built from code now and already got another error (which is to be expected cause I don't have a Ledger connected to that machine): ERROR Failed to create private key : Ledger not connected

At least now it is already looking for the Ledger hardware.

I tried to do a staking bsc-unbond - that activated a flow on my Ledger (seemed normal)
./bnbcli staking bsc-unbond --chain-id Binance-Chain-Tigris --side-chain-id bsc --from <<MYADDRESS>> --validator <<VALIDATOR ADDRESS>> --amount 100000000:BNB --node https://dataseed2.binance.org:443

I got this error back after SIGNING the transaction on Ledger:
ERROR: {"codespace":1,"code":4,"abci_code":65540,"message":"signature verification failed"}

Anyone ?
Possible reason : Do I need to create new keys with this new version of bnbcli for it to actually work , or can I just use my old keys that are already there (created by bnbcli v0.9.0?)

Additional potential cause:
̶I̶ ̶a̶m̶ ̶r̶u̶n̶n̶i̶n̶g̶ ̶v̶e̶r̶s̶i̶o̶n̶ ̶̶̶1̶.̶9̶.̶1̶9̶̶̶ ̶o̶f̶ ̶t̶h̶e̶ ̶B̶i̶n̶a̶n̶c̶e̶ ̶S̶m̶a̶r̶t̶ ̶C̶h̶a̶i̶n̶ ̶(̶B̶N̶B̶)̶ ̶a̶p̶p̶ ̶o̶n̶ ̶L̶e̶d̶g̶e̶r̶ ̶,̶ ̶t̶h̶e̶r̶e̶ ̶i̶s̶ ̶a̶n̶ ̶u̶p̶d̶a̶t̶e̶ ̶a̶v̶a̶i̶l̶a̶b̶l̶e̶ ̶t̶o̶ ̶̶̶1̶.̶1̶0̶.̶2̶̶̶ ̶-̶ ̶m̶a̶y̶b̶e̶ ̶t̶h̶a̶t̶ ̶a̶l̶s̶o̶ ̶h̶a̶s̶ ̶s̶o̶m̶e̶t̶h̶i̶n̶g̶ ̶t̶o̶ ̶d̶o̶ ̶w̶i̶t̶h̶ ̶i̶t̶?̶
This was my mistake - Staking is done with the Binance app, not the Binance Smart Chain app (on Ledger)

Extra note:
Tried the above command on testnet, same result.

commented

can you try the latest version 1.10.2?

can you try the latest version 1.10.2?

Thank you for responding, altho:
Why would Binance Smart Chain app version matter? For staking, we are using Binance Chain app, not Binance Smart Chain app.

I was also wrong in mentioning it as a "potential cause"