tests fail with missing file /naughty-strings/blns.json
varioustoxins opened this issue · comments
varioustoxins commented
running tests on newly downloaded git repo gives an error
python3 pynmrstar/unit_tests 1 ✘ ╱ base ╱ at 22:29:50
Python version: 3.8.13 (default, Mar 28 2022, 06:16:26)
[Clang 12.0.0 ]
System platform: darwin
.......................E.....
======================================================================
ERROR: test_odd_strings (pynmrstar.unit_tests.TestPyNMRSTAR)
Make sure the library can handle odd strings.
----------------------------------------------------------------------
Traceback (most recent call last):
File "/xxx/PyNMRSTAR/pynmrstar/unit_tests/__init__.py", line 57, in test_odd_strings
with open(os.path.join(our_path, 'naughty-strings/blns.json')) as odd_string_file:
FileNotFoundError: [Errno 2] No such file or directory:
'/Uxxx/PyNMRSTAR/pynmrstar/unit_tests/naughty-strings/blns.json'
----------------------------------------------------------------------
Ran 29 tests in 3.974s
FAILED (errors=1)
Jon Wedell commented
Is this after running
git submodule init
git submodule update
in the repo as suggested on issue #113? If so, what was the output of those commands?
varioustoxins commented
oops re #113, had a crash at my end and it looked like it hadn't gone, but can see it now.
tried it and it worked ;-)
checked out of GitHub because I have forked and wanted to do some hacking...
varioustoxins commented
left a pull request to make unit tests more documented if you want it