bmoscon / cryptostore

A scalable storage service for cryptocurrency data

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Kraken] ValueError: Valid depths for Kraken are 10, 25, 100, 500 or 1000 - max_depth is not being set if not set in config

anovv opened this issue · comments

Describe the bug
if max_depth is not set in config, it is not being set to default properly when exchange object is initialised

See line 30-32 in kraken.py: max_depth=1000 is not being passed downstream, it passes None instead

Even if I set max_depth in config for l2, the problem is still there if I also add ticker feed in config (since it also initialises Kraken object with empty max_depth)

Trace
https://pastebin.com/HbWRLmVd

Config
https://pastebin.com/qwM42JKA

Operating System:
macOS

Cryptofeed Version
latest master

Ping ping, is there any update? Still getting this issue

Created PR with the fix bmoscon/cryptofeed#428

fixed in cryptostore